[ofw] RE: Latest WOF2-0\trunk build errors

[Smith, Stan]

Hello Leonid,
  The simple fact of the matter is I missed the rename of the two files when updating my src tree.
SVN access @ Intel is outside the Intel firewall which makes svn updates a lengthy (time wise) process. Reading all commit logs should be optional behavior - not required to update & build.

Long story short, I wasted 20 minutes or so figuring out that two files had been renamed which caused the build errors. A simple email note, would have alerted one to be aware of the filename changes.

Accidents happen, I know you will do better in the future.

Stan.

Leonid Keller wrote:
> Hi Stan,
>
> Let me first apologize for not sending the patch.
> The intention of the patch (as shown in the comment) is to add WPP
> support to mlx4_bus.
> We came here across a fault case, where WPP was the only tool that
> could help to understand what happens.
> And there was no WPP in mlx4_bus.
> So I added it and committed without preliminary discussion, being
> sure, that it could accelerate the process of stabilizing the WinOF
> stack.
> I did not think it can cause any problems, and I meant to send the
> patch to the community when I will find and fix the problem.
>
> Regarding the compilation errors you see.
> I don't see them here.
> May be you need to adjust your build scripts wrt renaming of two
> files, done in this patch.


>
> Leonid
>
>> -----Original Message-----
>> From: Smith, Stan [mailto:stan.smith at intel.com]
>> Sent: Friday, October 24, 2008 7:11 PM
>> To: Leonid Keller
>> Cc: ofw at lists.openfabrics.org
>> Subject: Latest WOF2-0\trunk build errors
>>
>>
>> Perhaps next time you commit to svn you would consider
>> behaving as an Open Source participant and announce what and
>> why you are committing?
>>
>> Of most importance when we are attempting to do a WinOF 'release'!
>>
>> Svn.1688
>> Deleted : /gen1/branches/WOF2-0/trunk/hw/mlx4/kernel/hca/verbs.c
>> Deleted : /gen1/branches/WOF2-0/trunk/hw/mlx4/kernel/hca/verbs.h
>>
>> Added : /gen1/branches/WOF2-0/trunk/hw/mlx4/kernel/hca/hverbs.c
>> Added : /gen1/branches/WOF2-0/trunk/hw/mlx4/kernel/hca/hverbs.h
>>
>> Thank you,
>>
>> Stan.
>>
>> BUILD: Elapsed time [0:00:44.819]
>> 1>Compiling - ulp\opensm\user\opensm\osm_sa_guidinfo_record.c
>> 2>BUILD: Linking for
>> 2>f:\openib-windows-svn\wof2-0\rc5\trunk\hw\mlx4\kernel\bus\drv
>> 2>directory 3>Precompiling - hw\mlx4\kernel\hca\precomp.h 2>Linking
>> Executable - bin\kernel\objchk_wlh_amd64\amd64\mlx4_bus.sys
>> 1>Compiling - ulp\opensm\user\opensm\osm_sa_guidinfo_record_ctrl.c
>> 3>f:\openib-windows-svn\wof2-0\rc5\trunk\hw\mlx4\kernel\hca\pr
>> ecomp.h(42 3>) : error C1083: Cannot open include file: 'hverbs.h':
>> No
>> such file or
>> 3>directory Precompiling - hw\mlx4\kernel\hca\precomp.h
>> 1>Compiling - ulp\opensm\user\opensm\osm_sa_informinfo.c
>> 3>f:\openib-windows-svn\wof2-0\rc5\trunk\hw\mlx4\kernel\hca\pr
>> ecomp.h(42 3>) : error C1083: Cannot open include file: 'hverbs.h':
>> No
>> such file or directory NMAKE : fatal error U1073: don't know
>> how to make
>> 'f:\openib-windows-svn\wof2-0\rc5\trunk\hw\mlx4\kernel\hca\obj
>> chk_wlh_amd64\amd64\hverbs.obj'
>> errors in directory
>> f:\openib-windows-svn\wof2-0\rc5\trunk\hw\mlx4\kernel\hca
>> nmake.exe /nologo BUILDMSG=Stop. -i BUILD_PASS=PASS2
>> LINKONLY=1 NOPASS0=1 MAKEDI R_RELATIVE_TO_BASEDIR= failed - rc = 2