[ofw] RE: [patch] fix_partitioning_support_in_xp_inf.patch

[Smith, Stan]

Hello,

Anatoly Greenblatt wrote:
> Hi Stan,
>
> The main idea behind the id change was to differentiate between
> primary adapter for each port and partitions. It was in netipoib
> since the partitions support was added but missed in ipoib-xp32.inf
>
> At the time when installer runs, partitions are not configured.
> Therefore it is ok that installer sets up only primary adapters
> IBA\IPOIB.


Checking existing RC1 WinOF installations, I do not find the device IBA\IPOIBP?
How and when is this device created?

Then at a minimum when uninstalling, as with the device IBA\IPOIB, the additional device IBA\IPOIBP needs to be scanned for and removed.

Stan.


>
> Regards,
> Anatoly.
>
> -----Original Message-----
> From: Smith, Stan [mailto:stan.smith at intel.com]
> Sent: Wednesday, September 10, 2008 02:52
> To: Anatoly Greenblatt; ofw at lists.openfabrics.org
> Subject: RE: [patch] fix_partitioning_support_in_xp_inf.patch
>
>
> Hello,
>   Is changing the device name from IBA\IPOIB --> IBA\IPOIBP necessary?
> The installer scripts all use IBA\IPOIB device name.
> Why only XP or did I miss similar mods to netipoib.inx?
>
> Thanks,
>
> Stan.
>
>
> Anatoly Greenblatt wrote:
>>  <<fix_partitioning_support_in_xp_inf.patch>> Hi,
>>
>> This fix adds missing lines in ipoib.inf in order to support
>> partitions in xp.
>>
>> I also noticed that xp inf is not stamped as regular inf and there
>> are some differences in ndi paramters.
>>
>> Regards,
>> Anatoly.
>>
>> Index: ulp/ipoib/kernel/netipoib-xp32.inf
>> ===================================================================
>> --- ulp/ipoib/kernel/netipoib-xp32.inf  (revision 1573)
>> +++ ulp/ipoib/kernel/netipoib-xp32.inf  (working copy) @@ -21,12
>> +21,15 @@
>>
>>  [OPENIB.ntx86]
>>  %IpoibDesc%      = Ipoib.DDInstall,    IBA\IPoIB   ; Internet
>> Protocol over InfiniBand Adapter
>> +%IpoibDescP%     = Ipoib.DDInstall,    IBA\IPoIBP  ; Internet
>> Protocol over InfiniBand Adapter with partition key
>>
>>  [OPENIB.ntamd64]
>>  %IpoibDesc%      = Ipoib.DDInstall,    IBA\IPoIB   ; Internet
>> Protocol over InfiniBand Adapter
>> +%IpoibDescP%     = Ipoib.DDInstall,    IBA\IPoIBP  ; Internet
>> Protocol over InfiniBand Adapter with partition key
>>
>>  [OPENIB.ntia64]
>>  %IpoibDesc%      = Ipoib.DDInstall,    IBA\IPoIB   ; Internet
>> Protocol over InfiniBand Adapter
>> +%IpoibDescP%     = Ipoib.DDInstall,    IBA\IPoIBP  ; Internet
>> Protocol over InfiniBand Adapter with partition key
>>
>>  [Ipoib.DDInstall.ntx86]
>>  Characteristics = 0x81 ; NCF_HAS_UI | NCF_VIRTUAL
>> @@ -206,6 +209,7 @@
>>  [Strings]
>>  OPENIB               = "OpenIB Alliance"
>>  IpoibDesc            = "OpenIB IPoIB Adapter"
>> +IpoibDescP           = "OpenIB IPoIB Adapter Partition"
>>  IpoibServiceDispName = "IPoIB"
>>  IcsDisk1             = "OpenIB IPoIB Disk #1"
>>  DIRID_SYSTEM         = 11