[ofw] patch 2/2 Add support for RDMAoEth to the low level driver

James Yang jyang at xsigo.com
Thu Dec 3 15:28:12 PST 2009


1) 

 > >--- core/al/kernel/al_cm_cep.c (revision 2617)
> >+++ core/al/kernel/al_cm_cep.c (working copy)
> >@@ -4390,6 +4390,10 @@
> >
> >  p_av->attr.grh_valid = !ib_gid_is_link_local( &p_path->dgid );
> >
> >+ // make this same as Linux code: p_path->hop_flow_raw >= 2
> means grh present.
> >+ if(cl_hton32(p_path->hop_flow_raw) >= 2)  p_av->attr.grh_valid = 1;
> 
> Please submit this as a separate patch, and it would be best to decide 
> on a single way to set grh_valid.
> 
> 

This is required otherwise remote cm (like linux) will not use gid for the communication and failed cm.



2) 

> Other QP connection parameters (QPN, LID) are automatically discovered 
> and exchanged by the libibverbs sample programs.
> Why have the user specify this one value, rather than letting each 
> side discover the GIDs using a local query?
> 

This remote gid is used to let local knows where to send info. Just like an ip address. 
It's not IB environment. For simple test program like pingpong, specify gid here makes life easy. Otherwise how do you find out remote gid? 


Thanks,
James



More information about the ofw mailing list