[ofw] IBBUS - prevent IOU mgr duplicate deref on al obj h_ca

Smith, Stan stan.smith at intel.com
Mon May 18 12:20:24 PDT 2009


Hello,
  When disabling the HCA driver and there is an SRP target in the fabric, the iou manger can decrement the IOU's PDO hca refcnt count twice which leads to a IBAL ASSERT failure in ibbus.
Indicate the HCA reference is removed in iou_mgr_iou_remove() so it is not dereferenced again in free_iou_mgr().

I can commit upon your approval.

Thank you,

Stan.


Signed off by stan.smith at intel.com

diff U3 C:/Documents and Settings/scsmith/Local Settings/Temp/bus_iou-revBASE.svn006.tmp.c C:/Documents and Settings/scsmith/My Documents/openIB-windows/SVN/gen1/trunk/core/bus/kernel/bus_iou_mgr.c
--- C:/Documents and Settings/scsmith/Local Settings/Temp/bus_iou-revBASE.svn006.tmp.c  Mon May 18 12:08:21 2009
+++ C:/Documents and Settings/scsmith/My Documents/openIB-windows/SVN/gen1/trunk/core/bus/kernel/bus_iou_mgr.c  Mon May 18 12:08:04 2009
@@ -893,6 +893,8 @@
        p_pnp_rec->pnp_rec.context = NULL;

        deref_al_obj( &p_ext->h_ca->obj );
+       p_ext->h_ca = NULL;
+
        cl_mutex_release( &gp_iou_mgr->pdo_mutex );

        BUS_EXIT( BUS_DBG_PNP );
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bus_iou_mgr.c.patch
Type: application/octet-stream
Size: 653 bytes
Desc: bus_iou_mgr.c.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20090518/af82c338/attachment.obj>


More information about the ofw mailing list