[ofw] RE: IBBUS - reduce high volume debug output

[Smith, Stan]

Leonid Keller wrote:
> Go ahead.

Committed as svn.2187

Thank you,

Stan.
>
>> -----Original Message-----
>> From: Smith, Stan [mailto:stan.smith at intel.com]
>> Sent: Monday, May 18, 2009 9:44 PM
>> To: Leonid Keller
>> Cc: ofw at lists.openfabrics.org
>> Subject: IBBUS - reduce high volume debug output
>>
>>
>> Hello,
>>   When attempting to debug ibbus, the windbg console is
>> filled with extra ENTER/EXIT dbg output from bus_drv_open,
>> bus_drv_cleanup, bus_drv_ioctl.
>> This patch removes the BUS_ENTER/BUS_EXIT calls from
>> functions which have a high call frequency. Removing this
>> potential noise allows one to focus on higher level debug output.
>>
>> I can commit on your approval.
>>
>> Thank you,
>>
>> Stan.
>>
>> Signed off by stan.smith at intel.com
>>
>> diff U3 C:/Documents and Settings/scsmith/Local
>> Settings/Temp/bus_driver-revBASE.svn002.tmp.c C:/Documents
>> and Settings/scsmith/My
>> Documents/openIB-windows/SVN/gen1/trunk/core/bus/kernel/bus_driver.c
>> --- C:/Documents and Settings/scsmith/Local
>> Settings/Temp/bus_driver-revBASE.svn002.tmp.c       Mon May 18
>> 11:41:53 2009 +++ C:/Documents and Settings/scsmith/My
>> Documents/openIB-windows/SVN/gen1/trunk/core/bus/kernel/bus_dr
>> iver.c   Mon May 18 11:41:41 2009
>> @@ -738,8 +738,6 @@
>>         if( g_al_dbg_flags & AL_DBG_ERR )
>>                 g_al_dbg_flags |= CL_DBG_ERROR;
>>
>> -       // For manageable Debug output: Disable Enter/Exit macros in
>> -       //  bus_drv_ioctl(), bus_drv_open(), bus_drv_cleanup()
>>         //bus_globals.dbg_lvl |= BUS_DBG_DRV | BUS_DBG_PNP |
>> BUS_DBG_POWER;  #endif
>>
>> @@ -760,8 +758,6 @@
>>         IN                              DEVICE_OBJECT
>>         *p_dev_obj, IN                              IRP
>>                                   *p_irp )
>>  {
>> -       BUS_ENTER( BUS_DBG_DRV );
>> -
>>         UNUSED_PARAM( p_dev_obj );
>>
>>         CL_ASSERT( KeGetCurrentIrql() == PASSIVE_LEVEL ); @@ -771,7
>>         +767,6 @@ p_irp->IoStatus.Information = 0;
>>         IoCompleteRequest( p_irp, IO_NO_INCREMENT );
>>
>> -       BUS_EXIT( BUS_DBG_DRV );
>>         return STATUS_SUCCESS;
>>  }
>>
>> @@ -783,8 +778,6 @@
>>  {
>>         NTSTATUS                        status;
>>
>> -       BUS_ENTER( BUS_DBG_DRV );
>> -
>>         UNUSED_PARAM( p_dev_obj );
>>
>>         CL_ASSERT( KeGetCurrentIrql() == PASSIVE_LEVEL ); @@ -800,7
>>         +793,6 @@ p_irp->IoStatus.Information = 0;
>>         IoCompleteRequest( p_irp, IO_NO_INCREMENT );
>>
>> -       BUS_EXIT( BUS_DBG_DRV );
>>         return status;
>>  }
>>
>> @@ -829,8 +821,6 @@
>>         bus_fdo_ext_t           *p_ext;
>>         PIO_STACK_LOCATION      p_io_stack;
>>
>> -       BUS_ENTER( BUS_DBG_DRV );
>> -
>>         /* Get the extension. */
>>         p_ext = p_dev_obj->DeviceExtension;
>>
>> @@ -873,7 +863,6 @@
>>         IoReleaseRemoveLock( &p_ext->cl_ext.remove_lock, p_irp );
>>         IoReleaseRemoveLock( &p_ext->cl_ext.stop_lock, p_irp );
>>
>> -       BUS_EXIT( BUS_DBG_DRV );
>>         return status;
>>  }