[ofw] RE: [PATCH 1/2] contain pthreads defs with ifdef HAVE_LIBPTHREAD

Smith, Stan stan.smith at intel.com
Wed Nov 4 14:42:13 PST 2009


Hefty, Sean wrote:
>> Contain pthread definitions with ifdef HAVE_LIBPTHREAD
>>
>> Signed-off-by: stan smith <stan.smith at intel.com>
>>
>> diff --git a/opensm/include/vendor/osm_vendor_ibumad.h
>> b/opensm/include/vendor/osm_vendor_ibumad.h
>> index 0a4692d..d523412 100644
>> --- a/opensm/include/vendor/osm_vendor_ibumad.h
>> +++ b/opensm/include/vendor/osm_vendor_ibumad.h
>> @@ -160,8 +160,13 @@ typedef struct _osm_vendor {
>>      char ca_names[OSM_UMAD_MAX_CAS][UMAD_CA_NAME_LEN];
>>      vendor_match_tbl_t mtbl; umad_port_t umad_port;
>> +#ifdef HAVE_LIBPTHREAD
>>      pthread_mutex_t cb_mutex;
>>      pthread_mutex_t match_tbl_mutex;
>> +#else
>> +    cl_mutex_t cb_mutex;
>> +    cl_mutex_t match_tbl_mutex;
>> +#endif
>
> complib is available on both platforms, why not just use it?
>
> Alternately, #define cl_mutex_t pthread_mutex_t and avoid the #ifdef's

Pthreads have been workin just fine, no need fix something that is not broken.



More information about the ofw mailing list