[ofw] RE: [PATCH] remove unnecessary leading '/' from filename
Smith, Stan
stan.smith at intel.com
Sat Nov 28 08:30:46 PST 2009
Sasha Khapyorsky wrote:
> Hi Stan,
>
> On 15:18 Mon 12 Oct , Smith, Stan wrote:
>>
>> I believe removing the starting '/' from guid2lid filename is the
>> correct fix for a couple of reasons: 1) prefixing a / to a filename
>> seems strange when the path name is spec'ed as having a trailing / ?
>
> I agree. We need to care about making path properly rather than
> introduce a restrictions for directory names definitions.
>
> Sasha
Hello,
OK on proper paths.
What about the excellent point you raised in previous discussions about those pathnames which are input from environment vars which could be improperly formed? For badly formed paths from ENV vars (lacking trailing '/'), is it sufficient to let open() fail and output path/filename to osm log file?
Stan.
More information about the ofw
mailing list