[ofw] [PATCH] opensm - standardize on a single Windows #define

Smith, Stan stan.smith at intel.com
Mon Oct 12 15:24:45 PDT 2009


Sasha Khapyorsky wrote:
> On 10:16 Thu 08 Oct     , Smith, Stan wrote:
>> Hefty, Sean wrote:
>>>> Code cleanup, standardize on a single Windows #define '__WIN__';
>>>> WIN32 --> __WIN__. Flip usage of ifndef WIN32 --> ifdef __GNUC__
>>>
>>> GNUC indicates a specific compiler, not a platform, which is what
>>> the check is for.
>>
>> To the best of my understanding OpenSM is built for Linux/OFED,
>> Solaris and Windows.
>
> Also some embedded platforms and we don't know what in a future.
>
> '#ifdef __WIN__' and '#ifndef __GNUC__' are not equivalent.
>
> Sasha

You wish to live with the negative logic of ifndef __WIN__ ?

How about ifdef __linux__  ?






More information about the ofw mailing list