[ofw] [PATCH] opensm - standardize on a single Windows #define

Smith, Stan stan.smith at intel.com
Mon Oct 12 15:29:38 PDT 2009


Smith, Stan wrote:
> Sasha Khapyorsky wrote:
>> On 10:16 Thu 08 Oct     , Smith, Stan wrote:
>>> Hefty, Sean wrote:
>>>>> Code cleanup, standardize on a single Windows #define '__WIN__';
>>>>> WIN32 --> __WIN__. Flip usage of ifndef WIN32 --> ifdef __GNUC__
>>>>
>>>> GNUC indicates a specific compiler, not a platform, which is what
>>>> the check is for.
>>>
>>> To the best of my understanding OpenSM is built for Linux/OFED,
>>> Solaris and Windows.
>>
>> Also some embedded platforms and we don't know what in a future.
>>
>> '#ifdef __WIN__' and '#ifndef __GNUC__' are not equivalent.
>>
>> Sasha
>
> You wish to live with the negative logic of ifndef __WIN__ ?
>
> How about ifdef __linux__  ?

If __linux__ doesn't work for you, then please create a Linux Platform define I can use.

>
>
>
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw




More information about the ofw mailing list