[ofw] RE: [PATCH] umad - add missing item from latest management tree

Smith, Stan stan.smith at intel.com
Fri Oct 16 16:34:43 PDT 2009


Hefty, Sean wrote:
>>> That doesn't really explain anything.  How is opensm using this
>>> value, and what assumptions does it make about its size?  We should
>>> make sure that we have the right fix here.
>>
>> Why are you being so difficult to work with here?
>
> You're asking to change code with zero explanation as to why the code
> needs to change.
>
>> OpenSM 3.2.? added the value to umad.h file and referenced it in
>> osm_vendor_umad.c.
>
>> If you have issues with the code, then take it up with those who
>> wrote the code and stop impeding forward progress of getting a
>> sorely needed newer revision of OpenSM to the Windows community.
>
> If you want to change the windows version of libibumad, then submit a
> patch against that code with a reason why that change is needed.  The
> #define that you gave in the patch is wrong.  The limit is much, much
> higher on windows.
>
> - Sean

Libvendor would not compile without the ulp\libibumad\include\infiniband\unmad.h fix.
OFED management defines UMAD_CA_MAX_AGENTS in libibumad\include\infiniband\umad.h, it was not defined in the Windows version so I took the OFED value and placed it there.

Where exactly did you define it and why is it not in the expected OFED file? This seems like a bug.







More information about the ofw mailing list