[ofw] RE: Building the correct IPoIB version for the correct OS

[Smith, Stan]

Hello,
  Comments below.

Tzachi Dar wrote:
> Yes, you're right:
> 1. The "dirs" file should contains ipoib_NDIS6_CM 2. The add-on to
> makefile of ipoib based on NDIS 5:
> #
> # prevent the Build utility from building the driver for later #
> version of the operating system than windows 2003 #
> MAXIMUM_NT_TARGET_VERSION=0x502
>
> !INCLUDE ..\..\..\inc\openib.def
>
> 3. The add-on to makefile of ipoib based on NDIS 6:
> #
> # prevent the Build utility from building the driver for an earlier #
> version of the operating system than vista/Win 2008.
> #
> MINIMUM_NT_TARGET_VERSION=0x600
>
> !INCLUDE ..\..\..\inc\openib.def
>
> We already updated SVN with these changes on revision 2506.

OK.

One small question.
What is the logic in using a hard coded OS version constant instead of the self-documenting, MSFT suggested symbolic constant?

$(_NT_TARGET_VERSION_WS03)
$(_NT_TARGET_VERSION_VISTA)


>
> Thanks
> Tzachi
>
>> -----Original Message-----
>> From: Stan C. Smith [mailto:stan.smith at intel.com]
>> Sent: Friday, October 23, 2009 9:50 PM
>> To: Tzachi Dar
>> Cc: ofw at lists.openfabrics.org
>> Subject: Building the correct IPoIB version for the correct OS
>>
>>
>> Hello,
>>   Are you the correct person to be fielding IPoIB questions
>> these days? I'll assume so for now.
>>
>> Given the requirement NDIS6 IPoIB is only for Vista/Svr2008
>> and beyond, then to prevent ipoib.sys name space
>> overlap/overwrite, is the following what you had in mind for NDIS5.3
>> ipoib builds? Assumption is the ulp\dirs file contains entries for
>> both
>> ipoib & ipoib_ndis6_cm.
>>
>> --- C:/Documents and Settings/scsmith/Local
>> Settings/Temp/make-revBASE.svn004.tmp        Fri Oct 23 12:43:20 2009
>> +++ C:/Documents and Settings/scsmith/My
>> Documents/openIB-windows/SVN/gen1/trunk/ulp/ipoib/kernel/m
>> akefile      Fri Oct 23 12:44:57 2009
>> @@ -4,4 +4,8 @@
>>  # that is shared by all the driver components of the OpenIB Windows
>>  project. #
>>
>> +# Build this NDIS 5.3 ipoib for Windows versions prior to Vista/Svr
>> +2008 +
>> +#MAXIMUM_NT_TARGET_VERSION=$(_NT_TARGET_VERSION_WS03) +
>>  !INCLUDE ..\..\..\inc\openib.def