[ofw][patch][ibal] use non-pageable memory to prevent possible problems on power down

Leonid Keller leonid at mellanox.co.il
Tue Sep 15 01:14:52 PDT 2009


IBAL uses pageable memory to create PnP context.
It can create possible problems in power down flows at the time of
system contention.
 
We saw some similar case at a customer.
There is no strong evidence that that is what influenced, but with this
patch IBAL will be more safe and at no cost.
 
Found by Hobin Lee (Xsigo).
 
Index: kernel/al_pnp.c
===================================================================
--- kernel/al_pnp.c (revision 2421)
+++ kernel/al_pnp.c (working copy)
@@ -587,7 +587,7 @@
  CL_ASSERT( p_reg );
 
  /* No context exists for this port.  Create one. */
- p_context = (al_pnp_context_t*)cl_pzalloc( sizeof(al_pnp_context_t) );
+ p_context = (al_pnp_context_t*)cl_zalloc( sizeof(al_pnp_context_t) );
  if( !p_context )
  {
   AL_PRINT( TRACE_LEVEL_ERROR, AL_DBG_ERROR,

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20090915/070751a9/attachment.html>


More information about the ofw mailing list