[ofw][patch][ibal] use non-pageable memory to prevent possible problems on power down

Smith, Stan stan.smith at intel.com
Wed Sep 16 09:00:31 PDT 2009


Hello,
  This patch appears to have cured the sometimes BSOD on power-down. After 53 uninstalls I have yet to witness a BSOD!!
There was a similar patch to winverbs (paged vs. non-paged PNP struct allocation) which also cured a power-down BSOD, so it's not too surprising this patch has the same effect.
I will be including it in the WinOF 2.1 release (upcoming RC5).

stan.

________________________________
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Leonid Keller
Sent: Tuesday, September 15, 2009 1:15 AM
To: ofw_list
Subject: [ofw][patch][ibal] use non-pageable memory to prevent possible problems on power down

IBAL uses pageable memory to create PnP context.
It can create possible problems in power down flows at the time of system contention.

We saw some similar case at a customer.
There is no strong evidence that that is what influenced, but with this patch IBAL will be more safe and at no cost.

Found by Hobin Lee (Xsigo).

Index: kernel/al_pnp.c
===================================================================
--- kernel/al_pnp.c (revision 2421)
+++ kernel/al_pnp.c (working copy)
@@ -587,7 +587,7 @@
  CL_ASSERT( p_reg );

  /* No context exists for this port.  Create one. */
- p_context = (al_pnp_context_t*)cl_pzalloc( sizeof(al_pnp_context_t) );
+ p_context = (al_pnp_context_t*)cl_zalloc( sizeof(al_pnp_context_t) );
  if( !p_context )
  {
   AL_PRINT( TRACE_LEVEL_ERROR, AL_DBG_ERROR,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20090916/f87cc91f/attachment.html>


More information about the ofw mailing list