[ofw] [Patch][ipoib][ipoib_NDIS6_CM] Fixing a bug when OID_GEN_NETWORK_LAYER_ADDRESSES contains bad data

[Fab Tillier]

Ahh, ok.  Ignoring the addresses if there are more than one seems like the right thing to do then, at least for the time being.

-Fab

From: Alex Naslednikov [mailto:xalex at mellanox.co.il]
Sent: Tuesday, August 31, 2010 12:05 AM
To: Fab Tillier; Tzachi Dar; Hefty, Sean; ofw at lists.openfabrics.org
Subject: RE: [ofw] [Patch][ipoib][ipoib_NDIS6_CM] Fixing a bug when OID_GEN_NETWORK_LAYER_ADDRESSES contains bad data


The original patch did this, but put attention that it looks like the second NETWORK_ADDRESS structure overrides the first one, i.e. ALL the data are corrupted

See the data marked in red: 10 00 02 00 looks like the the start of the second structure, and even the first address has gone there.

I saw the same issue with 5 network addresses, it looked like

10 00 02 00 XX 10 00 02 00 XX 10 00 02 00 XX 10 00 02 00 XX 10 00 02 00 XX

Instead of:

10 00 02 00 { IP address of 16 bytes} 10 00 02 00 { IP address of 16 bytes}  10 00 02 00 { IP address of 16 bytes} 10 00 02 00 { IP address of 16 bytes}



4: kd> db 0xfffffa80`0c39f240

fffffa80`0c39f240  02 00 00 00 02 00 10 00-02 00 00 00 10 00 02 00  ................

fffffa80`0c39f250  0c 7f 00 00 10 04 0c 7f-00 00 00 00 00 00 00 00  ................

fffffa80`0c39f260  00 00 00 00 00 00 00 00-00 00 00 00 00 00 70 9f  ..............p.

fffffa80`0c39f270  04 00 08 02 45 76 65 ee-b4 05 00 00 b8 0b 00 00  ....Eve.........

fffffa80`0c39f280  00 00 00 00 70 00 00 00-00 00 00 00 00 00 00 00  ....p...........

fffffa80`0c39f290  00 00 00 00 00 00 00 00-00 00 00 00 00 00 00 00  ................

fffffa80`0c39f2a0  01 00 00 00 00 00 00 00-01 00 00 00 00 00 00 00  ................

fffffa80`0c39f2b0  00 00 00 00 00 00 00 00-0c 00 08 00 00 00 00 00  ................


-----Original Message-----
From: Fab Tillier [mailto:ftillier at microsoft.com]
Sent: Monday, August 30, 2010 9:56 PM
To: Tzachi Dar; Alex Naslednikov; Hefty, Sean; ofw at lists.openfabrics.org
Subject: RE: [ofw] [Patch][ipoib][ipoib_NDIS6_CM] Fixing a bug when OID_GEN_NETWORK_LAYER_ADDRESSES contains bad data

Thanks for sending this Tzachi, we're looking into it.

Tzachi Dar wrote on Mon, 30 Aug 2010 at 01:31:22

> On a more practical approach (assuming there is no fix in the short
> term) I suggest that on windows 2008 R2 we will not try to parse this
> structure if it contains more than one element. Please note that this
> means that ND will not work on such machines (with more than one ip
> address per interface).

Why not just only parse the first address only?

-Fab
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20100831/99a7d38e/attachment.html>