[ofw] [PATCH] INDAdatper::Query leaks CA attribute buffer

Hefty, Sean sean.hefty at intel.com
Tue Jun 1 17:59:05 PDT 2010


Btw - it would help if you marked this as the ibal/nd1 provider in the subject

> Need to free the temporary CA attribute buffer before returning.
> 
> Signed-off-by: Fab Tillier <ftillier at microsoft.com>
> 
> Index: NdAdapter.cpp
> ===================================================================
> --- NdAdapter.cpp	(revision 2818)
> +++ NdAdapter.cpp	(working copy)
> @@ -283,6 +283,7 @@ HRESULT CAdapter::Query(
>      pInfo->MaxCallerData = 56;
>      pInfo->MaxCalleeData = 148;
>      *pBufferSize = sizeof(ND_ADAPTER_INFO1);
> +    HeapFree( GetProcessHeap(), 0, pAttr );

I thought use of the process heap was to be avoided for ND providers?



More information about the ofw mailing list