[ofw] [PATCH] INDAdatper::Query leaks CA attribute buffer

Fab Tillier ftillier at microsoft.com
Tue Jun 1 20:20:43 PDT 2010


Hefty, Sean wrote on Tue, 1 Jun 2010 at 17:59:05

> Btw - it would help if you marked this as the ibal/nd1 provider in the
> subject

Doh, I just realized there was no path information whatsoever...  Sorry!

-Fab

> 
>> Need to free the temporary CA attribute buffer before returning.
>> 
>> Signed-off-by: Fab Tillier <ftillier at microsoft.com>
>> 
>> Index: NdAdapter.cpp
>> ===================================================================
>> --- NdAdapter.cpp	(revision 2818)
>> +++ NdAdapter.cpp	(working copy)
>> @@ -283,6 +283,7 @@ HRESULT CAdapter::Query(
>>      pInfo->MaxCallerData = 56;
>>      pInfo->MaxCalleeData = 148;
>>      *pBufferSize = sizeof(ND_ADAPTER_INFO1);
>> +    HeapFree( GetProcessHeap(), 0, pAttr );
> 
> I thought use of the process heap was to be avoided for ND providers?



More information about the ofw mailing list