>Seems fine by me. I believe that we should do the same in all the 3 definitions >of ib_port_attr_t to keep them the same. We have 3 definitions of the same structure? Where are the other two? I would vote for killing the duplicates