[ofw] [RFC] [PATCH] ibal: move transport type attribute

Smith, Stan stan.smith at intel.com
Mon Mar 8 08:45:44 PST 2010


Sean Hefty wrote:
>> Seems fine by me. I believe that we should do the same in all the 3
>> definitions of ib_port_attr_t to keep them the same.
>
> We have 3 definitions of the same structure?  Where are the other
> two?  I would vote for killing the duplicates
>
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw

If Tzachi is speaking to the ib_types.h found in the opensm\ source (Trunk\ulp\opensm\user\include\iba), then I would suggest skipping any mods there. This file is for reference purposes only; to aid in figuring out the differences between the Windows snapshot of opensm and the 'latest' Linux version when updating the windows opensm. The issue is the windows inc\iba\ib_types.h differs substantially from the Linux opensm version.
The file 'ib_types.h' is not utilized in the windows build process and 'could' be removed although it's removal implies additional work for the next opensm update.

stan.



More information about the ofw mailing list