[ofw] [RFC] [PATCH] ibal: move transport type attribute
Tzachi Dar
tzachid at mellanox.co.il
Mon Mar 8 08:57:24 PST 2010
Actually the structure is also defined in the ib_types_extended.h which is also under opensm directory.
Do we want to change that place?
Thanks
Tzachi
> -----Original Message-----
> From: Smith, Stan [mailto:stan.smith at intel.com]
> Sent: Monday, March 08, 2010 6:46 PM
> To: Hefty, Sean; Tzachi Dar; ofw at lists.openfabrics.org
> Subject: RE: [ofw] [RFC] [PATCH] ibal: move transport type attribute
>
> Sean Hefty wrote:
> >> Seems fine by me. I believe that we should do the same in
> all the 3
> >> definitions of ib_port_attr_t to keep them the same.
> >
> > We have 3 definitions of the same structure? Where are the
> other two?
> > I would vote for killing the duplicates
> >
> > _______________________________________________
> > ofw mailing list
> > ofw at lists.openfabrics.org
> > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
>
> If Tzachi is speaking to the ib_types.h found in the opensm\
> source (Trunk\ulp\opensm\user\include\iba), then I would
> suggest skipping any mods there. This file is for reference
> purposes only; to aid in figuring out the differences between
> the Windows snapshot of opensm and the 'latest' Linux version
> when updating the windows opensm. The issue is the windows
> inc\iba\ib_types.h differs substantially from the Linux
> opensm version.
> The file 'ib_types.h' is not utilized in the windows build
> process and 'could' be removed although it's removal implies
> additional work for the next opensm update.
>
> stan.
>
More information about the ofw
mailing list