[ofw] creating common ib_types.h for linux and windows

[Smith, Stan]

>-----Original Message-----
>From: linux-rdma-owner at vger.kernel.org [mailto:linux-rdma-owner at vger.kernel.org] On Behalf Of Alex Netes
>Sent: Wednesday, September 21, 2011 6:30 AM
>To: Hefty, Sean
>Cc: Bart Van Assche; linux-rdma (linux-rdma at vger.kernel.org); Hal Rosenstock (hal.rosenstock at gmail.com); ofw at lists.openfabrics.org
>Subject: Re: creating common ib_types.h for linux and windows
>
>On 14:23 Tue 20 Sep     , Hefty, Sean wrote:
>> > Why to test for __WIN__ instead of _WIN32 (defined both when building
>> > 32-bit and 64-bit code -- see also
>> > http://msdn.microsoft.com/en-us/library/b0084kay%28v=vs.80%29.aspx) ?
>>
>> I have no idea.  This is just what's currently in the code.  I can change this portion of the code if we want to use #ifdef's.
>>
>
>Digging into the history, I found this patch that added __WIN__ defined for
>Windows: http://www.spinics.net/lists/linux-rdma/msg00451.html

Hello Alex,
  The intent was to unify the multiple ifdef tags for Windows; perhaps _WIN32 might have been a better choice.
__WIN__ clearly indicates 'all' windows variants, while _WIN32 at 1st glance tends to imply 32bit Windows for those who are not aware of the MS confusing usage of _WIN32 also defined  for _WIN64 systems.
If you feel a change is needed then OK.

Stan.

>
>> > When creating a common header file, this might be a good start:
>> > https://msinttypes.googlecode.com/svn/trunk/stdint.h
>>
>> There are already shared types defined between linux and windows that opensm uses.  For the most part, there's no technical reason why
>windows can't use 99% of the linux ib_types.h as is.  My goal is to be able to take the file and drop it into the windows build tree without
>needing changes.
>
>What is your end goal? To have one code base for OpenSM that would be able to
>be compiled on both Linux and Windows based on __WIN__ definition?
>
>>
>> Btw, as background I tried to pull in the latest ibmad and ibdiags into windows.  The build broke because of new defines that had been
>added to ib_types.h.  Eventually we should be able to drop opensm directly into the windows build as well.
>>
>> - Sean
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>--
>
>-- Alex
>--
>To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>the body of a message to majordomo at vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html