[openib-general] version #defines for the kernel

Or Gerlitz ogerlitz at voltaire.com
Thu Dec 7 03:43:27 PST 2006


Eric Barton wrote:
> Hi,
> 
> I found out there has been a change in the kernel ib_fmr_pool_map_phys() to pass the
> last parameter by address rather than value.   I can cope with either version
> with by coding...  
> 
> +#if IB_USER_VERBS_ABI_VERSION < 6
>          fmr = ib_fmr_pool_map_phys(kiblnd_data.kib_fmrpool,
>                                     tx->tx_pages, npages,
>                                     &rd->rd_addr);
> +#else
> +        fmr = ib_fmr_pool_map_phys(kiblnd_data.kib_fmrpool,
> +                                   tx->tx_pages, npages,
> +                                   rd->rd_addr);
> +#endif
> 
> ...but is this the right thing to do?  It's the "USER" in
> IB_USER_VERBS_ABI_VERSION that's making me nervous since this is kernel code.

Indeed, it has nothing to do with user/kernel ABI, the FMR verbs are 
only exposed to kernel space consumers same for the FMR pool.

The ib_fmr_pool_map_phys api change was done in the 2.6.18 cycle

Or.





More information about the general mailing list