[nvmewin] 答复: patch submission

[Cheng Peng]

Hi Ray


Other colleagues take over my jobs, I have forwarded the email to them.


Thanks


________________________________
发件人: Robles, Raymond C <raymond.c.robles at intel.com>
发送时间: 2015年8月7日 3:34
收件人: nvmewin at lists.openfabrics.org; Cheng Peng
主题: RE: patch submission


Hi Cheng,



I have not seen a response from you on my question below. In order for your patch to be accepted, you must respond to any and all questions/comments from the reviewing companies… as well as from the reflector list. If you do not respond within a timely fashion, your patch will not be considered for integration to the OFA driver. Please respond at your earliest convenience.



Reviewing Companies,



Any feedback, questions, or test results on the patch submission below? The deadline for review is August 12th. Thanks!



Thanks,

Ray Robles



From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Friday, July 31, 2015 11:37 AM
To: nvmewin at lists.openfabrics.org; Cheng Peng
Subject: Re: [nvmewin] patch submission



Hi Cheng,



I’ve reviewed your code and have some questions.



It looks like NVMeWaitForCtrlRDY is added in init and reset path.  Previously controller ready wait is  performed in passive init path. I did not see any benefit of adding NVMeWaitForCtrlRDY in init path (I feel, old passive init path wait will be right approach to have minimal processor usage).



Could you please provide an explanation on why you moved wait for controller ready to init path?



Thanks,

Ray



From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Thursday, July 30, 2015 3:24 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>; Cheng Peng
Subject: Re: [nvmewin] patch submission



Reviewing Companies,



Please provide any review comments and testing results before August 12th. We also have a patch from ULINK Technology after this patch.



In the meantime, Cheng could you please provide the following information about your patch:



-          Reason fix was needed.

-          Files modified and what was modified in each file.

-          How you unit tested your fix.



Thanks,

Ray



From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Cheng Peng
Sent: Monday, July 06, 2015 10:32 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] patch submission



fix: Wait for device ready when enable adapter



It had been tested on Windows 2008 R2\Windows 2012 x64 platform



Please review it, and if you think it OK, please merge it to SVN trunk, thank you



Btw, the password of ZIP is ofa_nvme
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150808/5a9585a3/attachment.html>