[Openib-windows] RE: company name in OpenIB code

[Yossi Leybovich]

> -----Original Message-----
> From: Fab Tillier [mailto:ftillier at silverstorm.com] 
> Sent: Tuesday, November 01, 2005 7:22 PM
> To: 'Yossi Leybovich'
> Cc: openib-windows at openib.org
> Subject: RE: company name in OpenIB code
> 
> 
> Hi Yossi,
> 
> > From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> > Sent: Tuesday, November 01, 2005 4:56 AM
> > 
> > We still have 2 issues with embedded company name in the code 1.
> > the bus port mngr create the IpoIB devices with the name :
> > #define IPOIB_DESCRIPTION  L"InfiniCon IPoIB Adapter"
> > (I know that the inf change this value but we would like to 
> see it with the
> > right name from the begging)
> 
> This should be renamed "IPoIB Adapter", with no company name. 
>  I have zero interest in making the company name configurable.

OK . 

> 
> > 2.
> > In the duplicate flow the code create files with eth name 
> > "SilverStorm-PID- Identifier"
> > 
> > I think we should change it to be OpenIB or get the company 
> name from 
> > the env vars that the makefile define (which is better)
> 
> These files are never visible to anyone since they're not 
> true file system files.  The name is really irrelevant, and I 
> don't think that there's any value in letting them be 
> configurable via an environment variable.  I'm open to 
> changing it to reference OpenIB so feel free to send me a 
> patch, but this is a
> *really* low priority item to me.  There are far more 
> important things that we
> (collectively) should be spending time on than these 
> insignificant cosmetic issues.

I agree about the priority. But still need to clean the code , pls putt it
in your list.
> 
> Lastly, I am not at all interested in enabling branding of 
> what should be a single-source binary.  I'll take patches to 
> reference OpenIB, but will not take any patches that allow 
> individual branding.  It just doesn't make any sense - 
> companies should be using the OpenIB binaries, period.
> 

What about the inf files ? Do you want to remove them from the source tree ?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20051101/2a620886/attachment.html>