[ofw] ipv6_hdr_t fields should be net*_t ?

Smith, Stan stan.smith at intel.com
Wed Nov 10 12:11:06 PST 2010


Hello,
  A minor point although important.
In your recent commit 2984 inc\kernel\ip_packet.h, the ipv6_hdr_t fields which are > 8 bits should be typed as net*_t to indicate network byte ordering.
Do you agree?

thanks,

stan.

typedef struct _ipv6_hdr
 {
-       uint32_t        ver_tc_fl;
-       uint16_t        payload_length;
+       net32_t ver_tc_fl;
+       net16_t payload_length;
        uint8_t next_header;
        uint8_t hop_limit;
        uint8_t src_addr[16];



More information about the ofw mailing list