[ofw] [Patch] [IPoIB_NDIS6_CM] Remove wrong ASSERT

[Smith, Stan]

The first patch you supplied has this removal, the 2nd patch did not. When I checked the patch in I removed the ASSERT(FALSE).
Please note the line number in your patch is 4607, the same line is @ 4671.
Why is there such a skew?
Is there a problem sending me your version of ipoib_port.cpp?


________________________________
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Alex Naslednikov
Sent: Wednesday, September 01, 2010 7:15 AM
To: ofw at lists.openfabrics.org
Subject: [ofw] [Patch] [IPoIB_NDIS6_CM] Remove wrong ASSERT


The ASSERT assume that we never get a DHCP DISCOVERY msg with local MAC, while the original meaning was

not to get DHCP_INFORM message with non-local MAD.

Signed-Off by: Uri Habusha (urih at mellanox.co.il)

Index: B:/users/xalex/MLNX_WinOF-2_1_2/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp
===================================================================
--- B:/users/xalex/MLNX_WinOF-2_1_2/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp (revision 6300)
+++ B:/users/xalex/MLNX_WinOF-2_1_2/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp (revision 6301)
@@ -4607,7 +4607,6 @@
    if( p_cid[1] == HW_ADDR_LEN+1 && !cl_memcmp( &p_cid[3],
     &s_buf->p_port->p_adapter->params.conf_mac.addr, HW_ADDR_LEN ) )
    {
-    ASSERT( FALSE );
     /* Make sure there's room to extend it.  22 is the size of
      * the CID option for IPoIB. (20 is the length, one byte for type and the second for lenght field)
      */
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20100901/196046c3/attachment.html>