[nvmewin] Bug Fix Patch - Review Request

[Chang, Alex]

My concern is what if the allocation fails by any chance?

Alex

________________________________
From: Murray, Kris R [mailto:kris.r.murray at intel.com]
Sent: Thursday, October 25, 2012 10:23 AM
To: Chang, Alex; nvmewin at lists.openfabrics.org
Subject: RE: Bug Fix Patch - Review Request

Alex,
Since we don't use the returned pointer I believe there is no need to validate it. The goal is to cause Storport to allocate a DMA adapter object. See the attached email from James Harris for more info.
~Kris

From: Chang, Alex [mailto:Alex.Chang at idt.com]
Sent: Thursday, October 25, 2012 10:11 AM
To: Murray, Kris R; nvmewin at lists.openfabrics.org
Subject: RE: Bug Fix Patch - Review Request

Hi Kris,

I have a quick question regarding StorPortGetUncachedExtension:
The routine returns a pointer to the allocated buffer, should we validate the pointer before proceeding?

Thanks,
Alex

________________________________
From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org]<mailto:[mailto:nvmewin-bounces at lists.openfabrics.org]> On Behalf Of Murray, Kris R
Sent: Tuesday, October 16, 2012 10:07 AM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Bug Fix Patch - Review Request
Hi all,

The attached NVMe.zip file changes include the below fixes:

*        nvmeStd.c

o   Added a call to StorPortGetUncachedExtension to fix a checked OS assertion

*        nvmeSnti.c

o   Fixed SntiTranslateRead6 function to use the Read mask for the lba instead of the write mask

o   Fixed SntiTranslateWrite6 function to use the correct macro for getting 24 bits from the CDB using the correct offset

*        nvmeSntiTypes.h

o   Updated READ_6_CDB_LBA_MASK definition to match the one for write

o   Fixed WRITE_6_CDB_LBA_OFFSET from 0 to 1

The attached Results.zip file contains results from the test matrix below:

Operating Systems:

*        Windows 7

*        Windows 8

*        Windows Server 2008

*        Windows Server 2012

Tests:

*        IOMeter

*        SCSI Compliance

*        PCMark

Please review the changes, feeling free to send me comments and questions.

Thanks,
~Kris Murray
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20121025/1ac49c08/attachment.html>